Bug/assorted static analysis #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halfflat
suggested changes
Aug 1, 2021
arborio/cableio.cpp
Outdated
| @@ -584,7 +584,7 @@ eval_map named_evals{ | |||
| {"gap-junction-site", make_call<>(make_gap_junction_site, | |||
| "'gap-junction-site' with 0 arguments")}, | |||
| {"ion-reversal-potential-method", make_call<std::string, arb::mechanism_desc>(make_ion_reversal_potential_method, | |||
| "'ion-reversal-potential-method' with 2 ""arguments (ion:string mech:mechanism)")}, | |||
| "'ion-reversal-potential-method' with 2 arguments (ion:string mech:mechanism)")}, | |||
There was a problem hiding this comment.
Do we need this to be so indented?
halfflat
approved these changes
Aug 2, 2021
max9901
added a commit
to max9901/arbor
that referenced
this pull request
Aug 5, 2021
* Ci/sanitize (arbor-sim#1521) Add clang sanitizer passes to GH CI. * Tutorial structure: remove deduplication, includify (arbor-sim#1575) * added notes re literal_include to python examples * merged changes in arbor-sim#1504 * deduped and includified (arbor-sim#1558) tutorials. * First divergence of tutorial and code spotted! * Added some contrib documentation for examples and docs. * Implement mechanism ABI Implements arbor-sim#1376. * Provide a common C linkage ABI for externally compiled mechanisms, for both CPU and GPU. * Remove mechanism type hierarchy (`concrete_mechanism` etc.), and move corresponding functionality to the back-end shared state objects. Mechanism catalogue is no longer indexed by type id. * Distinguish between SIMD optimal alignment and SIMD width with new `min_align` attribute. Mechanisms provide both pieces of information via ABI. * update spack package to include fmt for arbor@0.5.3: (arbor-sim#1609) * alles werkt weer allen smol_dend niet;' * nu werkt het * Docs mechabi (arbor-sim#1610) * Bit of review on the copy of the mech abi docs. * Convert api/abi docs to C Domain directives. * Bug/assorted static analysis (arbor-sim#1615) * Fix failure to return value in `py_mech_cat_value_iterator `. * String butchered by formatting. * Join unnecessary separation of string literals in `arborio/cabelio.cpp` * Add missing throw in s_expr code. * Return value, not reference, in `merge_iterator::operator++(int)`. * Check for self-assignment in `mechanism_catalogue`. * Initialize all members of `mechanism`. * Fix index check order in `multi_event_stream` debug output. * Use coordinator_ from base class in `memory::array`. Co-authored-by: thorstenhater <24411438+thorstenhater@users.noreply.github.com> Co-authored-by: Brent Huisman <brenthuisman@users.noreply.github.com> Co-authored-by: Ben Cumming <bcumming@cscs.ch>
max9901
added a commit
to max9901/arbor
that referenced
this pull request
Aug 9, 2021
* Ci/sanitize (arbor-sim#1521) Add clang sanitizer passes to GH CI. * Tutorial structure: remove deduplication, includify (arbor-sim#1575) * added notes re literal_include to python examples * merged changes in arbor-sim#1504 * deduped and includified (arbor-sim#1558) tutorials. * First divergence of tutorial and code spotted! * Added some contrib documentation for examples and docs. * Implement mechanism ABI Implements arbor-sim#1376. * Provide a common C linkage ABI for externally compiled mechanisms, for both CPU and GPU. * Remove mechanism type hierarchy (`concrete_mechanism` etc.), and move corresponding functionality to the back-end shared state objects. Mechanism catalogue is no longer indexed by type id. * Distinguish between SIMD optimal alignment and SIMD width with new `min_align` attribute. Mechanisms provide both pieces of information via ABI. * update spack package to include fmt for arbor@0.5.3: (arbor-sim#1609) * Docs mechabi (arbor-sim#1610) * Bit of review on the copy of the mech abi docs. * Convert api/abi docs to C Domain directives. * Bug/assorted static analysis (arbor-sim#1615) * Fix failure to return value in `py_mech_cat_value_iterator `. * String butchered by formatting. * Join unnecessary separation of string literals in `arborio/cabelio.cpp` * Add missing throw in s_expr code. * Return value, not reference, in `merge_iterator::operator++(int)`. * Check for self-assignment in `mechanism_catalogue`. * Initialize all members of `mechanism`. * Fix index check order in `multi_event_stream` debug output. * Use coordinator_ from base class in `memory::array`. Co-authored-by: thorstenhater <24411438+thorstenhater@users.noreply.github.com> Co-authored-by: Brent Huisman <brenthuisman@users.noreply.github.com> Co-authored-by: Ben Cumming <bcumming@cscs.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a series of smaller issues found by PVS studio.