Revert "Add default hidden visibliity to pyarb shared lib. (#1510)" #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would open issue #1509 again. Do we know why the visibility changes made in #1510 break the build on Mac M1? We have just ordered a mac mini M1 system to use for testing, is it okay to wait for us to properly diagnose the issue? |
|
Hi. I don't know why the M1 build doesn't run correctly. Here's the pip install log w. current master if you would like to investigate: Good to hear that you're getting the M1 for test purposes. As long as I have a working fix for now I'm happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e8b08ca.
Closes #1557.