Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cable_global_properties readable #1802

Closed
Helveg opened this issue Jan 20, 2022 · 2 comments · Fixed by #1890
Closed

Make cable_global_properties readable #1802

Helveg opened this issue Jan 20, 2022 · 2 comments · Fixed by #1890
Labels
enhancement Feature Request help wanted neuroscience Project: Arborio

Comments

@Helveg
Copy link
Collaborator

Helveg commented Jan 20, 2022 •
edited
Loading

Like the decor, cable_global_properties is a one way bag, and what is put in can't be read out.

Describe the feature you need
Read operations of set_property and set_ion, and retrieving the catalogue one has registered.

Explain what it is supposed to enable
This is a problem for recipe composition (#1680). One can't read or merge the global properties of subrecipes.

Additional context
Arborio project needs to merge the recipe of the IO and CC
@llandsmeer
Copy link
Contributor

This would be useful for example in the implementation of 'top-level' recipes that merge a set of recipes into a single recipe: https://gist.github.com/llandsmeer/83a50458ddb134eb87e94cd3c3a77b27
This was surprisingly easy to implement, except for the distribution of global_properties() - because that function does not take a gid parameter.

@thorstenhater
Copy link
Contributor

thorstenhater commented May 5, 2022 •
edited
Loading

The catalogue now is a plain data member.
@llandsmeer you can iterate the catalogues and merge in mechs one by one (at least in C++).

@thorstenhater thorstenhater mentioned this issue May 5, 2022
Merged
brenthuisman pushed a commit that referenced this issue May 18, 2022
@thorstenhater
Add introspection for global properties. (#1890)
a408c1e 
Add accessors for the following items in `global_properties`
- ion_species (name -> valence) RO
- ion_data (name -> initial values) RO
- ion_rev_pot (name -> rev pot mech) RO
- Vm, rL, TK, Cm: RW

Fixes: #1802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature Request help wanted neuroscience Project: Arborio
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add introspection for global properties. thorstenhater/arbor
3 participants
@llandsmeer @thorstenhater @Helveg