Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the bundled mechanisms! #1155

Closed
halfflat opened this issue Sep 18, 2020 · 1 comment · Fixed by #1935
Closed

Clean up the bundled mechanisms! #1155

halfflat opened this issue Sep 18, 2020 · 1 comment · Fixed by #1935
Labels
code quality nmodl Interpretation or extension of NMODL.

Comments

@halfflat
Copy link
Contributor

Mechanisms currently included in the default catalogoue, such as hh, have various horrible NMODL descriptions. If nothing else, they make documenting correct usage much harder than it should be.

Proposal:

  • Get in there and clean up spurious GLOBALs and ASSIGN etc.
  • Restrict range parameters on density mechanisms to conductances and channel densities.
  • If we need to keep some for benchmarking purposes, we move them into their own catalogue.
@halfflat halfflat added code quality nmodl Interpretation or extension of NMODL. labels Sep 18, 2020
@halfflat
Copy link
Contributor Author

Some progress already — thanks @thorstenhater! — part of the clean up though may depend upon the resolution of #1380.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality nmodl Interpretation or extension of NMODL.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant