Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure post build artifact archiver step #158

Merged
merged 2 commits into from
Nov 13, 2014

Conversation

hubert
Copy link

@hubert hubert commented Nov 12, 2014

No description provided.

@@ -424,6 +425,40 @@ def add_skype_notification(params)
end
end

# Configure post-build step to archive artifacts
#
# @param params [Hash] parameters controlling how artifacts are archived
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be artifact_params instead of params?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or the method signature could be updated.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, those are not consistent. i'll fix and update.

@arangamani arangamani merged commit 9507e4f into arangamani:master Nov 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants