-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get current build artifact #147
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b1c8fe8
this new method is working but requires you to pass in login credenti…
10d8986
removed pry
8687e49
update to use Net::HTTP instead of curl
b7bd303
added notes to method
a68eeee
check for response.code, fix to use File.expand_path, and removed pry
08e5dc7
requested changes to jenkins api client, (sorry for the delay)
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,8 @@ | |
# | ||
|
||
require 'jenkins_api_client/urihelper' | ||
require 'net/https' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this library used in this file? If not it can be removed. |
||
require 'pry' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this was just used during debugging 😉 |
||
|
||
module JenkinsApi | ||
class Client | ||
|
@@ -1425,6 +1427,20 @@ def get_promotions(job_name) | |
result | ||
end | ||
|
||
#A Method to find artifacts path from the Current Build | ||
# | ||
# @param [String] job_name | ||
# | ||
def find_artifact(job_name) | ||
current_build_number = get_current_build_number(job_name) | ||
job_path = "job/#{path_encode job_name}/" | ||
response_json = @client.api_get_request("/#{job_path}#{current_build_number}") | ||
relative_build_path = response_json['artifacts'][0]['relativePath'] | ||
jenkins_path = response_json['url'] | ||
artifact_path = URI.escape("#{jenkins_path}artifact/#{relative_build_path}") | ||
return artifact_path | ||
end | ||
|
||
private | ||
|
||
# Obtains the threshold params used by jenkins in the XML file | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File.expand_path(filename)
should be better so relative paths work cleanly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this is going to simply store the response body regardless of the response. So checking if the response code is a success (200) before saving the body should be good.