Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] ADNI-to-BIDS converts only subjects in the provided ADNI directory if no subjects list is given #1196

Merged
merged 10 commits into from
Jun 3, 2024
Merged

[ENH] ADNI-to-BIDS converts only subjects in the provided ADNI directory if no subjects list is given #1196

merged 10 commits into from
Jun 3, 2024

Conversation

AliceJoubert
Copy link
Contributor

@AliceJoubert AliceJoubert commented May 29, 2024 •
edited
Loading

This PR adresses the behavior described in issue #398.

  • New functions were added in adni_utils.py to define the subjects list to convert, either from the given raw ADNI dataset or a subject list. Handles cases where there is no corresponding clinical data.
  • Unit tests were also added.

@AliceJoubert AliceJoubert added enhancement New feature or request converter labels May 29, 2024
@AliceJoubert AliceJoubert self-assigned this May 29, 2024
@AliceJoubert AliceJoubert marked this pull request as ready for review May 31, 2024 13:28
NicolasGensollen
NicolasGensollen reviewed May 31, 2024
View reviewed changes
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AliceJoubert !

I made a first pass and I think this looks good.
I made some small suggestions to simplify things but nothing major.

clinica/iotools/converters/adni_to_bids/adni_utils.py Outdated Show resolved Hide resolved
clinica/iotools/converters/adni_to_bids/adni_utils.py Outdated Show resolved Hide resolved
clinica/iotools/converters/adni_to_bids/adni_utils.py Outdated Show resolved Hide resolved
clinica/iotools/converters/adni_to_bids/adni_utils.py Outdated Show resolved Hide resolved
clinica/iotools/converters/adni_to_bids/adni_utils.py Outdated Show resolved Hide resolved
clinica/iotools/converters/adni_to_bids/adni_utils.py Show resolved Hide resolved
clinica/iotools/converters/adni_to_bids/adni_modalities/adni_tau_pet.py Outdated Show resolved Hide resolved
test/unittests/iotools/converters/adni_to_bids/test_adni_utils.py Outdated Show resolved Hide resolved
test/unittests/iotools/converters/adni_to_bids/test_adni_utils.py Show resolved Hide resolved
test/unittests/iotools/converters/adni_to_bids/test_adni_utils.py Outdated Show resolved Hide resolved
NicolasGensollen
NicolasGensollen approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @AliceJoubert !

test/unittests/iotools/converters/adni_to_bids/test_adni_utils.py Show resolved Hide resolved
@NicolasGensollen NicolasGensollen merged commit b142b96 into aramis-lab:dev Jun 3, 2024
14 of 15 checks passed
@AliceJoubert AliceJoubert deleted the adni2bids_only_on_directory_participants branch June 3, 2024 10:02
@AliceJoubert AliceJoubert mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasGensollen NicolasGensollen NicolasGensollen approved these changes

Assignees

@AliceJoubert AliceJoubert

Labels
converter enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AliceJoubert @NicolasGensollen