Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add threshold to fsl maths #68

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Conversation

NicolasGensollen
Copy link
Member

This PR proposes to add Threshold to the fsl.maths module.

@ghisvail I might have missed something since the following is not producing the right command line:

>>> from pydra.tasks import fsl
>>> t = fsl.maths.Threshold(threshold=0.0, input_image="toto.nii.gz", output_image="titi.nii.gz")
>>> t.cmdline
'fslmaths toto.nii.gz titi.nii.gz'

Command should be `'fslmaths toto.nii.gz -thr 0.0000 titi.nii.gz'

@ghisvail
Copy link
Collaborator

I have added a unit test to the module's doctest. Looks like it's working as intended.

@ghisvail
Copy link
Collaborator

I am not able to reproduce this bug anymore 😅

@ghisvail ghisvail merged commit 3342556 into aramis-lab:main Sep 29, 2023
11 checks passed
@NicolasGensollen NicolasGensollen deleted the add-threshold branch September 29, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants