Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectable arg selectors #15

Merged
merged 8 commits into from
Sep 25, 2022
Merged

Selectable arg selectors #15

merged 8 commits into from
Sep 25, 2022

Conversation

arainko
Copy link
Owner

@arainko arainko commented Sep 17, 2022

Resolves #14

Rework the way argument selectors are handled:

  • use Selectable instead of Dynamic which has better IDE supports (hints for refinements!)
  • drop NamedArgument and friends in place of a simple Nothing type fallback in FunctionArguments
  • workaround this dotty issue with a final class with a private constructor, of course you cannot call the contructor directly from inside an inline method but just creating a private def fixes it (AppliedViaBuilder and DefinitionViaBuilder)
  • annotate all builder methods with @compileTimeOnly and add NotQuotedException instead of runtime instances
  • cleanup all not private but internal classes
  • change the encoding of Identity to a final class with a private constructor

@arainko arainko force-pushed the selectable-arg-selectors branch 2 times, most recently from 26f1761 to 64c6a8a Compare September 25, 2022 01:16
…ilderConfig/ArgBuilderConfig, introduce NotQuotedException, add scalafix, hide all the internal classes, improve the 3.2.0 regression workaround
@arainko arainko force-pushed the selectable-arg-selectors branch from 64c6a8a to 3c42e07 Compare September 25, 2022 01:22
@arainko arainko merged commit d2df4e7 into master Sep 25, 2022
@arainko arainko deleted the selectable-arg-selectors branch December 29, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arg selectors with IDE hints in Scala 3.2 thanks to refinements in Selectable being autocompleted now
1 participant