-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Component: Details #729
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! Someone will review it soon 🔍 |
Evalir
reviewed
Mar 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New component 😍let's keep improving this so we can merge it!
- Renamed the component into Details. - Re-enable the sliding transition. - Improved pattern to prevent the animation on mount. - Coding style fixes.
Also add coding style changes.
sohkai
reviewed
Apr 9, 2020
sohkai
reviewed
Apr 9, 2020
Co-Authored-By: Brett Sun <qisheng.brett.sun@gmail.com>
Co-Authored-By: Brett Sun <qisheng.brett.sun@gmail.com>
sohkai
approved these changes
Apr 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #675 .
Changes
ToggleComponents
component and READMEDetails
A component to let users reveal content.
Usage
Props
label
Node
The heading, which is also the button users click to toggle the opened state.
children
Node
The content to reveal. Note that it this node is always mounted even when hidden, but this might change in the future.
opened
Boolean
When set, allows to control the state of
Details
from the outside (as a controlled component). Leave unset to letDetails
manage its own opened / closed state.onToggle
Function
Gets called when the opened states changes, or is requested to change if
opened
is set. Takes the new opened state as a single parameter (Boolean
).