-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix infinity loop issue #127
Conversation
Pay attention, the @notice parameter of the assignVested method in the TokenManagercontract breaks theradspec` parser: there is a infinity loop. Context: aragon/radspec#127
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any security issues with this change
@loga4 can you pls fix the lint issue? |
oh, my bad, sorry) |
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
+ Coverage 92.19% 93.23% +1.04%
==========================================
Files 37 37
Lines 756 769 +13
==========================================
+ Hits 697 717 +20
+ Misses 59 52 -7
Continue to review full report at Codecov.
|
Pay attention, the @notice parameter of the assignVested method in the TokenManagercontract breaks theradspec` parser: there is a infinity loop. Context: aragon/radspec#127
Pay attention, the
@notice
parameter of theassignVested
method in the TokenManagercontract breaks the
radspec` parser: there is a infinity loop.There are several options on how to fix this:
notice
in theTokenManager
contract;Considering that the
radspec
and Token Manager contract has not been updated for a long time - there is a proposal to go on the first and second point.