Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinity loop issue #127

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Conversation

loga4
Copy link
Contributor

@loga4 loga4 commented Jun 2, 2022

Pay attention, the @notice parameter of the assignVested method in the TokenManagercontract breaks theradspec` parser: there is a infinity loop.
There are several options on how to fix this:

  1. Correct the notice in the TokenManager contract;
  2. Add simple protection from infinity loop;
  3. Add a validation check for the AST tree.

Considering that the radspec and Token Manager contract has not been updated for a long time - there is a proposal to go on the first and second point.

@CLAassistant
Copy link

CLAassistant commented Jun 2, 2022

CLA assistant check
All committers have signed the CLA.

loga4 added a commit to loga4/aragon-apps that referenced this pull request Jun 2, 2022
Pay attention, the @notice parameter of the assignVested method in the TokenManagercontract breaks theradspec` parser: there is a infinity loop.

Context: aragon/radspec#127
Copy link

@Voronchuk Voronchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any security issues with this change

@githubdoramon
Copy link

@loga4 can you pls fix the lint issue?

@loga4
Copy link
Contributor Author

loga4 commented Jun 3, 2022

@loga4 can you pls fix the lint issue?

oh, my bad, sorry)
done

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #127 (040177a) into master (8aef856) will increase coverage by 1.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   92.19%   93.23%   +1.04%     
==========================================
  Files          37       37              
  Lines         756      769      +13     
==========================================
+ Hits          697      717      +20     
+ Misses         59       52       -7     
Impacted Files Coverage Δ
src/parser/index.js 90.09% <100.00%> (+4.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aef856...040177a. Read the comment docs.

@githubdoramon githubdoramon merged commit 5aff77c into aragon:master Jun 3, 2022
githubdoramon pushed a commit to aragon/aragon-apps that referenced this pull request Jun 3, 2022
Pay attention, the @notice parameter of the assignVested method in the TokenManagercontract breaks theradspec` parser: there is a infinity loop.

Context: aragon/radspec#127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants