feat(Beta): allow different name for token and organization #58
Conversation
…nization through one call
sohkai
changed the title
sohkai
requested review from
izqui and
bingen
and removed request for
bingen
sohkai
force-pushed
the
beta-allow-different-token-organization-name
branch
from
267cedc to
e189bee
Compare
| let aragonId, tokenName, tokenSymbol | ||
|
|
||
| before(async () => { | ||
| aragonId = 'multisigdao-' + Math.floor(Math.random() * 1000) |
There was a problem hiding this comment.
You would not believe how long it took me to realize that namehash('MultisigDao-<number>.aragonid.eth') doesn't create the same hash as the one the contract makes (sha3(namehash('aragonid.eth') + sha3('MultisigDao-<number>'))), due to the UTS46 normalization 😄 .
This bit was previously also giving aragonID incorrect ENS nodes to register (without the Math.floor(), Math.random() * 1000 gives something like 123.1234).
There was a problem hiding this comment.
Oh, wow, good catch both! And sorry about the first one, I didn't think of it.
|
@bingen can you take a look at these tests since it was you who mostly wrote them? |
|
Sure, I'll do! |
| let aragonId, tokenName, tokenSymbol | ||
|
|
||
| before(async () => { | ||
| aragonId = 'multisigdao-' + Math.floor(Math.random() * 1000) |
There was a problem hiding this comment.
Oh, wow, good catch both! And sorry about the first one, I didn't think of it.
As for now it's also going to be an ENS name (see aragon/dao-templates#58 for reference and improvement)
Adds the ability to specify a different token name from the organization's registered aragonID name.
This is especially important, as aragonID names lose a lot of freedom during UTS46 normalization (e.g. all uppercase characters).
Parameterizes the tests so that the suite is run for both types of organization creation, and adds a few more tests: