Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed App and Repo #93

Merged
merged 4 commits into from
Jul 1, 2020
Merged

Renamed App and Repo #93

merged 4 commits into from
Jul 1, 2020

Conversation

eternauta1337
Copy link
Contributor

As discussed, this PR applies the following names on the core entities:

  • Organization
  • Application => App
  • Repository => Repo
  • Role
  • Permission

Copy link
Contributor

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #93 into master will decrease coverage by 0.16%.
The diff coverage is 37.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   28.99%   28.82%   -0.17%     
==========================================
  Files          53       53              
  Lines         838      836       -2     
  Branches      137      137              
==========================================
- Hits          243      241       -2     
  Misses        595      595              
Flag Coverage Δ
#unittests 28.82% <37.93%> (-0.17%) ⬇️
Impacted Files Coverage Δ
...ages/connect-core/src/connections/ConnectorJson.ts 0.00% <0.00%> (ø)
packages/connect-core/src/entities/App.ts 0.00% <0.00%> (ø)
packages/connect-core/src/entities/Organization.ts 0.00% <0.00%> (ø)
packages/connect-core/src/entities/Permission.ts 0.00% <0.00%> (ø)
packages/connect-core/src/entities/Repo.ts 0.00% <0.00%> (ø)
packages/connect-core/src/index.ts 0.00% <0.00%> (ø)
...connect-core/src/transactions/TransactionIntent.ts 0.00% <ø> (ø)
...s/connect-core/src/transactions/TransactionPath.ts 0.00% <ø> (ø)
packages/connect-core/src/utils/app.ts 0.00% <0.00%> (ø)
...kages/connect-core/src/utils/path/calculatePath.ts 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c677e...63a5e43. Read the comment docs.

@0xGabi 0xGabi merged commit c22711d into master Jul 1, 2020
@0xGabi 0xGabi deleted the rename-app-and-repo branch July 1, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants