Add support for xdai network #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=======================================
Coverage 28.15% 28.15%
=======================================
Files 53 53
Lines 863 863
Branches 146 146
=======================================
Hits 243 243
Misses 620 620
Continue to review full report at Codecov.
|
bpierre
approved these changes
Jun 22, 2020
| if (chainId === 100) { | ||
| return { | ||
| chainId: 100, | ||
| name: 'xdai', |
There was a problem hiding this comment.
Just as a note, I was thinking of starting to accept the chain as { chainId: number, name: string } rather than only chainId: number, to handle staging environments.
sohkai
reviewed
Jun 23, 2020
Co-authored-by: Brett Sun <qisheng.brett.sun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1Hive is deploying Aragon Infrastructure to xDai and this is a requirement for
connectto keep compatible with it.