Fix: Add missing SubscriptionCallback types #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
==========================================
+ Coverage 34.93% 36.68% +1.74%
==========================================
Files 98 104 +6
Lines 1792 1922 +130
Branches 274 304 +30
==========================================
+ Hits 626 705 +79
- Misses 1166 1217 +51
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bpierre
approved these changes
Aug 25, 2020
| @@ -17,7 +17,7 @@ export function parseCollateralRequirement( | |||
| { | |||
| id: collateralRequirement.id, | |||
| voteId: collateralRequirement.vote.id, | |||
| token: collateralRequirement.token.id, | |||
| tokenId: collateralRequirement.token.id, | |||
There was a problem hiding this comment.
Should we update anything else related to this change? 🤔
There was a problem hiding this comment.
I double-check and no we don't. It was a change introduced during a merge conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CI adding missing SubscriptionCallback + update collateralRequirement tokenId