Update docs: Finance, Tokens and Voting #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to pass errors with subscriptions, the same way we do it for the async functions by throwing errors. Contains the following changes: - Add the add SubscriptionCallback type. - Add types to all the subscriptions methods. - Move all the subscription methods to use node-style callbacks. - Update documentation and examples.
Rather than separate ones, which creates less updates.
Together, this utility and type can be used to help app connectors declare their subscriptions easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #233 (should be merged after).
It documents the possibility of omitting the callback in
onXmethods, and also adds objects that were not documented:Finance:
TokenBalanceTransactionTokens:
TokenTokenHolderVoting:
VoteCast