Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethers: use named imports #208

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Ethers: use named imports #208

merged 2 commits into from
Aug 25, 2020

Conversation

bpierre
Copy link
Contributor

@bpierre bpierre commented Aug 18, 2020

This doesn’t change much at the moment (see issue on the ethers.js repo), but will make it possible to tree shake Ethers in the future.

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #208 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #208   +/-   ##
=======================================
  Coverage   34.72%   34.72%           
=======================================
  Files          99       99           
  Lines        1823     1823           
  Branches      291      291           
=======================================
  Hits          633      633           
  Misses       1190     1190           
Flag Coverage Δ
#unittests 34.72% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...connect-core/src/transactions/TransactionIntent.ts 0.00% <0.00%> (ø)
packages/connect-core/src/utils/app.ts 0.00% <0.00%> (ø)
packages/connect-core/src/utils/callScript.ts 0.00% <0.00%> (ø)
packages/connect-core/src/utils/descriptions.ts 0.00% <0.00%> (ø)
packages/connect-core/src/utils/forwarding.ts 0.00% <0.00%> (ø)
packages/connect-core/src/utils/kernel.ts 0.00% <0.00%> (ø)
packages/connect-core/src/utils/metadata.ts 0.00% <0.00%> (ø)
...kages/connect-core/src/utils/path/calculatePath.ts 0.00% <0.00%> (ø)
packages/connect-core/src/utils/radspec/index.ts 0.00% <ø> (ø)
packages/connect-core/src/utils/transactions.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3b5ac7...3a9188c. Read the comment docs.

@bpierre bpierre requested a review from 0xGabi August 23, 2020 01:49
Copy link
Contributor

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🙌

@bpierre bpierre merged commit e4cf7bb into master Aug 25, 2020
@bpierre bpierre deleted the ethers-named-imports branch August 25, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants