Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a global .prettierrc #201

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Add a global .prettierrc #201

merged 1 commit into from
Aug 12, 2020

Conversation

bpierre
Copy link
Contributor

@bpierre bpierre commented Aug 12, 2020

Also runs prettier on the entire codebase, except connect-voting-disputable to not break a PR being currently opened for this directory.

Also runs prettier on the entire codebase, except
connect-voting-disputable to not break a PR being currently opened for
this directory.
@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #201 into master will increase coverage by 0.05%.
The diff coverage is 28.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   34.91%   34.96%   +0.05%     
==========================================
  Files          98       98              
  Lines        1793     1799       +6     
  Branches      275      276       +1     
==========================================
+ Hits          626      629       +3     
- Misses       1167     1170       +3     
Flag Coverage Δ
#unittests 34.96% <28.98%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/connect-agreement/src/models/Agreement.ts 76.31% <0.00%> (-2.07%) ⬇️
...onnect-agreement/src/thegraph/parsers/agreement.ts 80.00% <ø> (ø)
...ages/connect-core/src/connections/ConnectorJson.ts 0.00% <0.00%> (ø)
packages/connect-core/src/entities/Permission.ts 0.00% <0.00%> (ø)
packages/connect-core/src/entities/Role.ts 0.00% <0.00%> (ø)
...connect-core/src/transactions/TransactionIntent.ts 0.00% <0.00%> (ø)
packages/connect-core/src/utils/app.ts 0.00% <0.00%> (ø)
packages/connect-core/src/utils/descriptions.ts 0.00% <0.00%> (ø)
...kages/connect-core/src/utils/path/calculatePath.ts 0.00% <0.00%> (ø)
packages/connect-core/src/utils/radspec/index.ts 0.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2aee9e...affefdd. Read the comment docs.

@bpierre bpierre merged commit df48e08 into master Aug 12, 2020
@bpierre bpierre deleted the prettier-fix branch August 12, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants