createAppConnector(): stop using instanceof #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The app instance passed to createAppConnector() might come from the a version of @aragon/connect-core that is a dependent of @aragon/connect, which is generally included as a direct dependency by the final app. createAppConnector() itself comes from the app connector package, which might contain a different version of @aragon/connect-core. These situations make the use of typeof impossible, as two App constructors would come from the two different modules. There are also other situations where linking one dependency (e.g. the app connector only) can create the same issue. This commits moves to duck typing to validate the App instance, which also make it work in these different scenarios.
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
- Coverage 34.93% 34.91% -0.02%
==========================================
Files 98 98
Lines 1792 1793 +1
Branches 274 275 +1
==========================================
Hits 626 626
- Misses 1166 1167 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app instance passed to
createAppConnector()might come from the a version of@aragon/connect-corethat is a dependent of@aragon/connect, which is generally included as a direct dependency by the final app.createAppConnector()itself comes from the app connector package, which might contain a different version of@aragon/connect-core.These situations make the use of
typeofimpossible, as twoAppconstructors would come from the two different modules.There are also other situations where linking one dependency (e.g. the app connector only) can create the same issue.
This commits moves to duck typing to validate the App instance, which also make it work in these different scenarios.