Refactor: Use an static method to create Entities + Split Data and Metadata #110
Conversation
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
- Coverage 28.12% 27.94% -0.18%
==========================================
Files 54 54
Lines 889 873 -16
Branches 145 142 -3
==========================================
- Hits 250 244 -6
+ Misses 639 629 -10
Continue to review full report at Codecov.
|
| data.manifest | ||
| ) | ||
|
|
||
| const metadata: Metadata = [artifact, manifest] |
There was a problem hiding this comment.
Now we have a clear distinction between data and metadata. Probably during creation as well we will handle the overrides of the few contract that miss repos on aragonPM (Kernel, ACL, EVM, etc)
| return this.#metadata[1] as AragonManifest | ||
| } | ||
|
|
||
| get abi(): Abi { |
There was a problem hiding this comment.
I only include getter for really useful properties. Otherwise, the dev can get them from the metadata files.
| await repoEntity.create(data) | ||
|
|
||
| return repoEntity | ||
| return Repo.create(data, connector) |
There was a problem hiding this comment.
This is how we create the entities now.
No description provided.