Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile #810

Closed
wants to merge 25 commits into from
Closed

Profile #810

wants to merge 25 commits into from

Conversation

Schwartz10
Copy link
Contributor

No description provided.

@@ -0,0 +1,9 @@
import ipfsClient from 'ipfs-http-client'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used js-ipfs-ctl to find out if there is a local ipfs daemon running, maybe check before going for infura?

@bpierre bpierre changed the title Dev Profile May 29, 2019
@bpierre bpierre requested review from bpierre and AquiGorka May 29, 2019 15:55
@Schwartz10
Copy link
Contributor Author

Schwartz10 commented May 29, 2019

@stellarmagnet can you provide the V1 profile designs please?

Instructions for running this branch. In your terminal, first clone the repo:
git clone git@github.com:openworklabs/aragon.git

Get the development branch:
git fetch origin dev
git checkout dev

install deps:
npm i

start the app:
cd aragon
npm run start:with:profiles

Navigate to http://localhost:3000/ and create an organization on rinkeby. Once on your organization, you have to manually navigate to profiles via the url bar:

Your profile:
http://localhost:3000/#/<ENS-NAME>/profile/

Someone else's profile:
http://localhost:3000/#/<ENS-NAME>/profile/<ETHEREUM-ADDRESS>

Example:
http://localhost:3000/#/schwartzzilla.aragonid.eth/profile/0x501D456ed92F1223D71208A8e6d3F77761174AF1

next steps
As discussed with @bpierre and @AquiGorka:

(immediate)

  • decide if we should make the Profile its own separate repo + node module and include it in aragon/aragon as a dependency. My vote is yes - publish as a separate package - it should make future maintenance way smoother and scales better for future native apps developed by non-A1 teams.

(not immediate)

  • code cleanup with a useProfile hook (can't wait to implement this :))
  • figure out how to use the app identity badge (or something similar) in the signing panel to show the aragon profile application requested a user's signature
  • figure out how to remove ipfs as a dep (we're only using this to add image files to IPFS, so maybe we can ask 3box to build this functionality into their api)
  • remove momentjs as a dep in favor of https://date-fns.org/
  • use pixes for sizing
  • match styles (like grid units, margins...etc) with native aragon designs

@Schwartz10
Copy link
Contributor Author

decide if we should make the Profile its own separate repo + node module and include it in aragon/aragon as a dependency.

Realizing this will also depend on how we integrate with the identity provider stuff. I haven't thought too deep into how the codes would work for this yet.

@Schwartz10
Copy link
Contributor Author

Just spoke again with @AquiGorka about strategy for including profiles in the client. We have some good ideas, but will still need opinion/confirmation from @sohkai when he's available again.

Key takeaways:

  • It's best to include the profile work as some sort of external dependency. Updating and maintaining profiles as part of the Aragon client repo would require a lot of resources from A1 for code reviews.
  • The profile module should be rendered in some type of iframe. The type of iframe to use is a wip - Gorka is going to look a little deeper into this issue. If no good or simple solution is found, one solid alternative is to provide a special iframe for the profile app with the allow-iframe-origin header set in the sandbox.

For now I'm going to work on publishing aragon profile as a node module

@CLAassistant
Copy link

CLAassistant commented May 30, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ Schwartz10
✅ rkzel
❌ chadoh
You have signed the CLA already but the status is still pending? Let us recheck it.

chadoh added 7 commits May 30, 2019 16:36
* Remove background white color & unnecessary padding on column at
  narrow widths
* Use consistent styling for links
* Left-align & consistently size icons
* Absolutely position edit pencil, so content is full width
* Wrap ethereum address at narrow widths
* Add spacing between banner and info box
* Adjust IconVerified color
placeholder requires a few styles to differ, not only background-image
Also, use an actual button element, which improves accessibility.
@Schwartz10
Copy link
Contributor Author

Hey, a quick update.

I've been wrestling with module bundlers (rollup) to try and publish a bundled version of the Profile application. Most of the trouble has been to properly compile 3box and its dependencies without adding a ton of memory usage to the Aragon client bundling process (npm run start:with:profiles). I briefly debugged this with @bpierre yesterday, and am working on addressing this with their team. Conversation here.

@Schwartz10
Copy link
Contributor Author

Also @bpierre - some of the IPFS bundling issues we were running into yesterday, especially with large memory usage could probably be related to: ipfs/js-ipfs#1927

@bpierre
Copy link
Contributor

bpierre commented Jun 5, 2019

@Schwartz10 interesting, thanks! 👀

@Schwartz10 Schwartz10 closed this Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants