-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile #810
Profile #810
Conversation
src/apps/Profile/ipfs/index.js
Outdated
@@ -0,0 +1,9 @@ | |||
import ipfsClient from 'ipfs-http-client' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've used js-ipfs-ctl
to find out if there is a local ipfs daemon running, maybe check before going for infura?
@stellarmagnet can you provide the V1 profile designs please? Instructions for running this branch. In your terminal, first clone the repo: Get the development branch: install deps: start the app: Navigate to Your profile: Someone else's profile: Example: next steps (immediate)
(not immediate)
|
Realizing this will also depend on how we integrate with the identity provider stuff. I haven't thought too deep into how the codes would work for this yet. |
Just spoke again with @AquiGorka about strategy for including profiles in the client. We have some good ideas, but will still need opinion/confirmation from @sohkai when he's available again. Key takeaways:
For now I'm going to work on publishing aragon profile as a node module |
replaced rems with pixels
|
* Remove background white color & unnecessary padding on column at narrow widths * Use consistent styling for links * Left-align & consistently size icons * Absolutely position edit pencil, so content is full width * Wrap ethereum address at narrow widths * Add spacing between banner and info box * Adjust IconVerified color
placeholder requires a few styles to differ, not only background-image
Also, use an actual button element, which improves accessibility.
Hey, a quick update. I've been wrestling with module bundlers (rollup) to try and publish a bundled version of the Profile application. Most of the trouble has been to properly compile 3box and its dependencies without adding a ton of memory usage to the Aragon client bundling process ( |
Also @bpierre - some of the IPFS bundling issues we were running into yesterday, especially with large memory usage could probably be related to: ipfs/js-ipfs#1927 |
@Schwartz10 interesting, thanks! 👀 |
Profiles design tweaks
No description provided.