Refactor Viewport to useViewport hook (for some components) #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AquiGorka
changed the title
AquiGorka
force-pushed
the
feature/use-viewport-hook
branch
from
0edd892 to
7cf2020
Compare
AquiGorka
force-pushed
the
feature/app-center-app-details
branch
from
7739e40 to
7bfc477
Compare
25 tasks
AquiGorka
force-pushed
the
feature/app-center-app-details
branch
2 times, most recently
from
1e681d8 to
9bec3aa
Compare
AquiGorka
force-pushed
the
feature/use-viewport-hook
branch
from
7cf2020 to
4f7d49f
Compare
AquiGorka
added a commit
that referenced
this pull request
Apr 29, 2019
* Update aragonUI version * AppContent: refactor Viewport to useViewport hook * DaoSettings: refactor Viewport to useViewport hook * AppInstanceLabel: refactor Viewport to useViewport hook * NavigationItem: refactor Viewport to useViewport hook * Preferences: refactor Viewport to useViewport hook * AppInstanceLabel: add react memo to avoid re-renders * DaoSettings: add react memo to avoid re-renders
AquiGorka
added a commit
that referenced
this pull request
Apr 30, 2019
* Add remark deps * Screenshots: add key to list items * AppContent: add app details parsed from markdown * AppContent: add app details to use all available space in larger viewports * AppContent: add right padding to app details * AppContent: refactor var name to use camel case * AppContent: use details from latest version * AppContent: override links with SafeLinks in markdown * AppContent: add two column layout for larger screens * AppContent: update useEffect to usePromise (which is cancellable) * Hooks: add usePromise * Refactor Viewport to useViewport hook (for some components) (#753) * Update aragonUI version * AppContent: refactor Viewport to useViewport hook * DaoSettings: refactor Viewport to useViewport hook * AppInstanceLabel: refactor Viewport to useViewport hook * NavigationItem: refactor Viewport to useViewport hook * Preferences: refactor Viewport to useViewport hook * AppInstanceLabel: add react memo to avoid re-renders * DaoSettings: add react memo to avoid re-renders * AppContent: reorder elements, remove 2 column details and add 2 column content for larger screens * Markdown: add component * AppContent: refactor details to use markdown component * Markdown: add react memo * Hooks: add use repo details hook * AppContent: update to useRepoDetails hook and refactor links * AppContent: update repo name link to use block explorer url * AppContent: use repo address instead of repo name for link * Add li rules to markdown context Co-Authored-By: AquiGorka <gorka@aquigorka.com> * Add focus rules to markdown context Co-Authored-By: AquiGorka <gorka@aquigorka.com> * useRepoDetails: update error log * Markdown: fix linter error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #750 to avoid conflicts.