Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App center polish #751

Merged
merged 4 commits into from
Apr 29, 2019
Merged

App center polish #751

merged 4 commits into from
Apr 29, 2019

Conversation

sohkai
Copy link
Contributor

@sohkai sohkai commented Apr 25, 2019

Super small items:

  • Avoid rendering the UpgradeOrganizationPanel when not necessary
  • Filter the list of repos included in the UpgradeOrganizationPanel to only include known ones
  • Default an app's description in the App Center to "No description." to avoid a dangling header

@sohkai sohkai requested a review from bpierre April 25, 2019 09:41
AquiGorka
AquiGorka approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@AquiGorka AquiGorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ❤️

@luisivan luisivan mentioned this pull request Apr 29, 2019
Closed
25 tasks
bpierre
bpierre approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇵🇱

@sohkai sohkai merged commit 3d39bfe into master Apr 29, 2019
@sohkai sohkai deleted the app-center-polish branch April 29, 2019 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpierre bpierre bpierre approved these changes

@AquiGorka AquiGorka AquiGorka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sohkai @bpierre @AquiGorka