chore: update babel's present-env configuration

[sohkai]

See babel/babel#11451.

While this is not a problem locally because we have a yarn.lock, it breaks users who try to install using npm (e.g. users of the CLI).

Without this change, we get errors like:

If you'd like to use two separate instances of a plugin,
they need separate names, e.g.

  plugins: [
    ['some-plugin', {}],
    ['some-plugin', {}, 'some unique name'],
  ]

Duplicates detected are:
[
  {
    "alias": "/Users/brett/Development/aragon/aragon/node_modules/@babel/plugin-proposal-class-properties/lib/index.js",
    "dirname": "/Users/brett/Development/aragon/aragon",
    "ownPass": false,
    "file": {
      "request": "@babel/plugin-proposal-class-properties",
      "resolved": "/Users/brett/Development/aragon/aragon/node_modules/@babel/plugin-proposal-class-properties/lib/index.js"
    }
  },
  {
    "alias": "base$3",
    "options": {
      "loose": "#__internal__@babel/preset-env__prefer-false-but-true-is-ok-if-it-prevents-an-error"
    },
    "dirname": "/Users/brett/Development/aragon/aragon",
    "ownPass": false
  }
]
    at assertNoDuplicates (/Users/brett/Development/aragon/aragon/node_modules/@babel/core/lib/config/config-descriptors.js:206:13)
    at createDescriptors (/Users/brett/Development/aragon/aragon/node_modules/@babel/core/lib/config/config-descriptors.js:114:3)
    at createPluginDescriptors (/Users/brett/Development/aragon/aragon/node_modules/@babel/core/lib/config/config-descriptors.js:105:10)
    at /Users/brett/Development/aragon/aragon/node_modules/@babel/core/lib/config/config-descriptors.js:63:53
    at cachedFunction (/Users/brett/Development/aragon/aragon/node_modules/@babel/core/lib/config/caching.js:62:27)
    at cachedFunction.next (<anonymous>)
    at evaluateSync (/Users/brett/Development/aragon/aragon/node_modules/gensync/index.js:244:28)
    at sync (/Users/brett/Development/aragon/aragon/node_modules/gensync/index.js:84:14)
    at plugins (/Users/brett/Development/aragon/aragon/node_modules/@babel/core/lib/config/config-descriptors.js:28:77)
    at mergeChainOpts (/Users/brett/Development/aragon/aragon/node_modules/@babel/core/lib/config/config-chain.js:319:26)

[sohkai]

NOTE: pins the yarn.lock's web3 version to 1.2.6, as with 1.2.7+, we start erroring due to the upgraded websocket dependency.

Turns out this wasn't the problem, and we can leave it unpinned.

[bpierre]

Nice, that also gives us a few other things https://github.com/babel/website/blob/0d482dd7ed3451592549009483423f7d37d2fe92/docs/preset-env.md#shippedproposals

[bpierre]

Just wondering if babel was complaining without the shippedProposals: true?

[sohkai]

Honestly didn't check, but just ruled it out of my mind since it was behaving differently between yarn and npm at that point after I initially did the yarn upgrade-interactive.

[sohkai]

Went back to the commit and checked; this was not the problem. The problem was we had multiple versions of babel installed, and I believe an older one was still being used by parcel at that time.

[rperez89]

what is shippedProposals?

[bpierre]

@rperez89 that’s an option of @babel/preset-env to enable ES features that are shipped in browsers, regardless of their TC39 stage: https://github.com/babel/website/blob/0d482dd7ed3451592549009483423f7d37d2fe92/docs/preset-env.md#shippedproposals

[sohkai]

It turns out yarn upgrade-interactive doesn't do a great job of deduping.

Doing a yarn remove and then yarn add to re-install these dependencies (the only ones that had babel dependencies) properly dedupes the babel versions and makes the build work.

However, I cannot figure out why the websocket module's require() is still failing tests. Even going back to jest v25.1.0 and pushing everything else to be the same as master, it still fails now 🤷‍♂️. Perhaps also a good sign that we should not be creating a websocket connection in our tests :).

[sohkai]

Going to let this close for now, we can upgrade this setting at a later time if necessary (since this was only for the dev tools to work well).