Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fallbacks external #359

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Make fallbacks external #359

merged 1 commit into from
Jul 26, 2018

Conversation

sohkai
Copy link
Contributor

@sohkai sohkai commented Jul 16, 2018

Fixes #327.

@sohkai sohkai requested review from izqui and bingen July 16, 2018 01:34
bingen
bingen approved these changes Jul 16, 2018
View reviewed changes
Copy link
Contributor

@bingen bingen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sohkai sohkai merged commit 540c4ae into dev Jul 26, 2018
@sohkai sohkai deleted the fallback-external branch July 26, 2018 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bingen bingen bingen approved these changes

@izqui izqui izqui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sohkai @izqui @bingen