Skip to content

Commit

Permalink
AppProxyFactory: emit appId in NewAppProxy event (#311)
Browse files Browse the repository at this point in the history
  • Loading branch information
sohkai authored May 15, 2018
1 parent 5e6f4b7 commit b8691e9
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions contracts/factory/AppProxyFactory.sol
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ import "../apps/AppProxyPinned.sol";


contract AppProxyFactory {
event NewAppProxy(address proxy, bool isUpgradeable);
event NewAppProxy(address proxy, bool isUpgradeable, bytes32 appId);

function newAppProxy(IKernel _kernel, bytes32 _appId) public returns (AppProxyUpgradeable) {
return newAppProxy(_kernel, _appId, new bytes(0));
}

function newAppProxy(IKernel _kernel, bytes32 _appId, bytes _initializePayload) public returns (AppProxyUpgradeable) {
AppProxyUpgradeable proxy = new AppProxyUpgradeable(_kernel, _appId, _initializePayload);
NewAppProxy(address(proxy), true);
NewAppProxy(address(proxy), true, _appId);
return proxy;
}

Expand All @@ -23,7 +23,7 @@ contract AppProxyFactory {

function newAppProxyPinned(IKernel _kernel, bytes32 _appId, bytes _initializePayload) public returns (AppProxyPinned) {
AppProxyPinned proxy = new AppProxyPinned(_kernel, _appId, _initializePayload);
NewAppProxy(address(proxy), false);
NewAppProxy(address(proxy), false, _appId);
return proxy;
}
}

0 comments on commit b8691e9

Please sign in to comment.