API: propagate errors to single-response APIs #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2color
reviewed
Apr 9, 2019
| filter((message) => message.id === id) | ||
| filter((message) => message.id === id), | ||
| map((response) => { | ||
| if (response.error) { |
There was a problem hiding this comment.
Is there any reason not to leave the response.error an error instance in https://github.com/aragon/aragon.js/blob/master/packages/aragon-rpc-messenger/src/jsonrpc.js#L19?
It seems like we are converting an error to a string in jsonrpc.js and back to an error here.
There was a problem hiding this comment.
Primarily because sending an Error instance through postMessage() will fail: see things that don't work with the structured clone algorithm.
2color
approved these changes
Apr 9, 2019
This was referenced Apr 9, 2019
Closed
sohkai
added a commit
to aragon/client
that referenced
this pull request
Apr 10, 2019
…entity modification (#686) Coupled with aragon/aragon.js#277, apps will now receive errors on `requestAddressIdentityModification()`.
sohkai
added a commit
to aragon/aragon-apps
that referenced
this pull request
Apr 18, 2019
Fixes aragon/client#734. With aragon/aragon.js#277 we now get the actual errors back from the RPC when a call goes wrong (e.g. naive `token.symbol()` on DAI) and we need to handle these explicitly. This PR converts a lot of the token fallback-related bits into simpler Promise-based code and adds explicit handlers for their error cases.
2color
added a commit
to 2color/aragon.js
that referenced
this pull request
Apr 26, 2019
…th-cache * origin/master: (29 commits) Update README.md (aragon#291) Wrapper: clarify comments about forwarding path finding strategy (aragon#289) Split quick start doc from intro (aragon#287) @aragon/wrapper 5.0.0-rc.2 wrapper: prettify setApp() descriptions (aragon#284) wrapper: fix callsscripts decoding (aragon#283) Wrapper: add installedRepos observable (aragon#268) fix: avoid infinitely looping through forwarders when looking for a transaction path (aragon#285) wrapper: enforce message to sign is string (aragon#282) api: v1.1.0 rpc-messenger: v1.1.0 feat: @aragon/wrapper api cleanup (aragon#279) Wrapper: handle SetApp for updated apps (aragon#267) feat: Add message signing (aragon#276) Wrapper: don't assign initializationBlock on non-kernel proxies when unneeded (aragon#266) chore: ignore package-lock.jsons (aragon#280) API: propagate errors to single-response APIs (aragon#277) Rpc Messenger: dedupe message bus across requests (aragon#278) Fix: changes after review (aragon#274) Docs update: include react api, aragon app architecture & fixes (aragon#271) ...
This was referenced Jul 8, 2019
nickhabets
added a commit
to nickhabets/aragon
that referenced
this pull request
Dec 29, 2020
Fixes aragon/client#734. With aragon/aragon.js#277 we now get the actual errors back from the RPC when a call goes wrong (e.g. naive `token.symbol()` on DAI) and we need to handle these explicitly. This PR converts a lot of the token fallback-related bits into simpler Promise-based code and adds explicit handlers for their error cases.
nickhabets
pushed a commit
to nickhabets/aragon
that referenced
this pull request
Dec 29, 2020
Fixes aragon/client#734. With aragon/aragon.js#277 we now get the actual errors back from the RPC when a call goes wrong (e.g. naive `token.symbol()` on DAI) and we need to handle these explicitly. This PR converts a lot of the token fallback-related bits into simpler Promise-based code and adds explicit handlers for their error cases.
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
Fixes aragon/client#734. With aragon/aragon.js#277 we now get the actual errors back from the RPC when a call goes wrong (e.g. naive `token.symbol()` on DAI) and we need to handle these explicitly. This PR converts a lot of the token fallback-related bits into simpler Promise-based code and adds explicit handlers for their error cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now callers of single response APIs will be able to catch errors from the call that are propagated through
@aragon/wrapper.They can either do this by including an error handler to their
.subscribe()or by turning the returned observable into a promise and using the standard promise-rejection handling methods.A good example of where this is useful is for transaction signing and message signing, where the user may ultimately reject or cancel the intent.