-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract logic from "dao act" #970
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #970 +/- ##
===========================================
+ Coverage 20.22% 20.82% +0.59%
===========================================
Files 106 108 +2
Lines 2442 2449 +7
===========================================
+ Hits 494 510 +16
+ Misses 1948 1939 -9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@macor161 I think that at this point, we should be able to at least isolate the call to execHandler in lib/ and write a test for it. Otherwise |
@ajsantander Agreed, I will refactor it in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate the logic on the execHandler
make it much more clear 💪
I have included a couple of commits with changes of #928
I think we can merge this one and focus on integration test on a new PR
🦅 Pull Request
Ref #874 and #947
🚨 Test instructions
dao act
TODO
execHandler
execHandler