Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract logic from "dao act" #970

Merged
merged 11 commits into from
Dec 4, 2019
Merged

Extract logic from "dao act" #970

merged 11 commits into from
Dec 4, 2019

Conversation

macor161
Copy link
Contributor

@macor161 macor161 commented Nov 27, 2019

🦅 Pull Request

Ref #874 and #947

🚨 Test instructions

dao act

TODO

  • Refactor execHandler
  • Test execHandler

@macor161 macor161 changed the title Extract logic from dao act Extract logic from "dao act" Nov 27, 2019
@0xGabi 0xGabi mentioned this pull request Nov 27, 2019
43 tasks
@macor161 macor161 changed the title Extract logic from "dao act" WIP Extract logic from "dao act" Nov 27, 2019
@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #970 into develop will increase coverage by 0.59%.
The diff coverage is 28.07%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #970      +/-   ##
===========================================
+ Coverage    20.22%   20.82%   +0.59%     
===========================================
  Files          106      108       +2     
  Lines         2442     2449       +7     
===========================================
+ Hits           494      510      +16     
+ Misses        1948     1939       -9
Impacted Files Coverage Δ
packages/aragon-cli/src/commands/dao_cmds/exec.js 0% <0%> (ø) ⬆️
packages/aragon-cli/src/commands/dao_cmds/act.js 0% <0%> (ø) ⬆️
packages/aragon-cli/src/lib/dao/exec.js 0% <0%> (ø)
...gon-cli/src/commands/dao_cmds/utils/execHandler.js 0% <0%> (ø) ⬆️
packages/aragon-cli/src/lib/dao/encodeActCall.js 100% <100%> (ø)
packages/aragon-cli/src/lib/getAppKernel.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d70b41b...7f21223. Read the comment docs.

@macor161 macor161 changed the title WIP Extract logic from "dao act" Extract logic from "dao act" Nov 27, 2019
Copy link
Contributor

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@theethernaut
Copy link
Contributor

⚠️

@macor161 I think that at this point, we should be able to at least isolate the call to execHandler in lib/ and write a test for it. Otherwise dao act ends up not being tested as a whole...

@macor161
Copy link
Contributor Author

macor161 commented Dec 2, 2019

@ajsantander Agreed, I will refactor it in this PR.

@macor161 macor161 changed the title Extract logic from "dao act" WIP Extract logic from "dao act" Dec 2, 2019
Copy link
Contributor

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate the logic on the execHandler make it much more clear 💪

I have included a couple of commits with changes of #928

I think we can merge this one and focus on integration test on a new PR

@0xGabi 0xGabi changed the title WIP Extract logic from "dao act" Extract logic from "dao act" Dec 4, 2019
@0xGabi 0xGabi merged commit 5552275 into develop Dec 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the sdk7-dao-act branch December 4, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants