-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor entire codebase for separating logic from commands #858
Comments
@dapplion feel free to choose from the list and comment in this issue thread to update the list☝️ |
@0xGabi I'll start with acl commands if it's okay. |
I'll take the deploy command too |
I can take |
@dapplion You want to take some of the other middleware tasks? Note: I plan to push a PR to remove the deprecated code of the network option and init command, probably today. That will be updating a bit the |
@0xGabi I can tackle the rest of the middleware tasks. |
@ajsantander @0xGabi You can mark the remaining middlewares as downhill |
I consider this issue done. We tackle most of the tasks and those still not done were decided to address on #947 or move to the developer flow. |
Planning
Planning document, here.
Following @0x6431346e's proposal on how to separate logic from commands, we're ready to start implementing this in the code.
Preliminary tasks
Having completed these preliminary tasks, we're ready to start implementing the refactor, with the following considerations:
lib/
folder following thetoken new
command's example (Refactor token new #856).Refactor based on commands
After refactoring the commands
lib/
folderlib/
listr
context variables: SDK: v7 aragonone/product#222 (comment)commandDir
and order by priority / usageSuggested next steps
lib/
folder to a new package so that it can be bootstrapped to use TypescriptThe text was updated successfully, but these errors were encountered: