-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finance: refactor to new styles for 0.8 #929
Merged
Merged
Changes from all commits
Commits
Show all changes
107 commits
Select commit
Hold shift + click to select a range
e769e00
Remove unused file
AquiGorka e0a22da
TransferFilters: update to new styles
AquiGorka 98ed369
Transfers: update to new styles and remove unused stuff
AquiGorka db9acaa
Balances: update to new styles
AquiGorka 63eddda
Transfer types: update copy
AquiGorka 6a04221
BalanceToken: refactor to new styles
AquiGorka e37025b
DatePicker: update button base styles
AquiGorka d9dc0f4
DateRangePicker: remove unused var and update one liner
AquiGorka cd108a3
Add main container component
AquiGorka 821e3d5
App: refactor to new styles
AquiGorka 610a8f4
Transfers: fix download check
AquiGorka ac4efc6
Transfers: fix download of filtered transfers
AquiGorka f985d94
Remove unused components
AquiGorka 5d98ca3
Transfers: fix prop types
AquiGorka 120cf0d
Transfers: remove checkboxes and accompanying functionality
AquiGorka 615d083
Transfers: hide filters on small layouts for the time being
AquiGorka b0b6363
Add no results svg
AquiGorka cde3431
EmptyFilteredTransfers: add component
AquiGorka 5490804
Transfers: add empty card for zero filtered transfers
AquiGorka 3df9790
Autocomplete: use border radius from aragon ui
AquiGorka 541da0f
AutoCompleteSelected: use radius from aragon ui and pass down button …
AquiGorka bdc1edd
LocalIdentitiesAutoComplete: update styles
AquiGorka 47912a3
DateRangeInput: add labels to avoid showing text with monospaced font
AquiGorka 19db0d4
Transfer types: update copy
AquiGorka 42375a3
Transfers: update dropdowns imports and api
AquiGorka 29862db
DateRangeInput: update selected date range accented status
AquiGorka bf20a95
TransfersFilters: update dropdown interface
AquiGorka c5314f2
Transfers: use page instead of current page
AquiGorka cb34eb4
Deposit: update default value for dropdown
AquiGorka 7a45b99
TokenSelector: fix dropdown interface and width
AquiGorka ba5baae
Withdrawal: fix dropdown api
AquiGorka 4c6ff51
TransfersFilters: update dropdown component
AquiGorka e8fda94
Finance: deploy preview to now (#938)
sohkai 40a2702
App: sort imports
AquiGorka 3e3dce8
TokenSelector: fix handler when setting custom token address
AquiGorka d37bce0
LocalIdentitiesAutoComplete: use experimental autocomplete component
AquiGorka e0df595
Remove local autocomplete
AquiGorka fed7cc3
TokenSelector: update comment
AquiGorka 987e3b0
TransferFilters: remove added option to symbols
AquiGorka eeda882
Transfers: add all tokens option to filter
AquiGorka 18d6f58
EmptyFilteredTransfers: add height for image to avoid jump on loading
AquiGorka 1aa5a2d
Remove unused component and hooks
AquiGorka e079d04
Transfers: move const declaration up with others
AquiGorka 265c9cd
Transfers: use new theme all around
AquiGorka 14d4659
Transfers: move function nearer other friendly functions
AquiGorka b93f09a
Transfers: add noopener to external link
AquiGorka 6aaa0d2
Transfers: remove selection count renderer from DataView
AquiGorka 7b86fc3
BalanceToken: refactor fractional styles
AquiGorka 4836e10
Withdrawals: update info to warning mode
AquiGorka 484530a
Update aragon ui version
AquiGorka 11cd603
TransfersFilters: update dropdown interface
AquiGorka e64bd01
Transfers: update selected options zero to display placeholder
AquiGorka fbc8e25
index.html: Override default overflow
AquiGorka e3aaad0
Finance: update DatePicker
sohkai 49a89e7
Finance: update token list
sohkai 918b1fa
Finance: remove unused icons
sohkai d57f022
Finance: update for new DropDown API
sohkai 8705776
Finance: use new useTheme() consistently
sohkai a0ef4ff
Finance: use grid units consistently
sohkai bc28573
Finance: update validation errors for new icon styling
sohkai f9bbad9
Finance: update for new Tag
sohkai ec36ae8
Finance: move small styled components to inline declarations
sohkai 258c108
Finance: use TokenBadge from aragonUI
sohkai e4e333b
Finance: use constants for transfers filters
sohkai dea5507
Finance: fix no token found validation error appearing without token …
sohkai a6ff9ec
Finance: fix passed prop for disabled
sohkai 4782806
Finance: render the TokenBadge in all deposit situations (outside of …
sohkai 39f4a74
Finance: add margin to withdrawal panel's validation error
sohkai f6d5a81
Finance: deprecate <Text/> for textStyles()
sohkai 59eca44
Finance: update deprecated <Info/> components
sohkai 7eb6dc7
Finance: update LocalIdentityBadge to apply the network type by default
sohkai 4aa95d2
Finance: fix passing props in styled components requiring theming
sohkai 8645584
Add no transfers illustration
AquiGorka c8d8877
EmptyTransactions: add component
AquiGorka 3aafbce
Transfers: render empty transfers when it there are no transfers
AquiGorka 556e16b
Balances: add empty balances state
AquiGorka 068cab4
Transfers: fix header padding
AquiGorka b85af29
DateRange: update color and remove shadow
AquiGorka c0c19b3
Transfers: update export button styles
AquiGorka d4a3fa9
EmptyFilteredTransfers: udpate copy
AquiGorka f6dbff8
Deposit: remove info title and update copy
AquiGorka 50cfe38
TokenSelectorInstance: update addresses to use readOnly & compact Ide…
AquiGorka f1941f0
Withdrawal: add space between amount and token list
AquiGorka 3d37fa1
EmptyFilteredTransfers: udpate copy
AquiGorka 888bcc1
Deposit: remove duplicate text
AquiGorka 3102992
TokenSelectorInstance: fix incorrect prop
AquiGorka abce5be
TransfersFilters: use DateRange from aragonUI
AquiGorka 2bd051c
Remove local DateRange
AquiGorka 42a2499
Finance: update context menu items to fit new style
sohkai c727b57
Finance: remove duplicated or unnecessary nodes from App's layout
sohkai 54fac34
Finance: make empty transaction view's vertical padding slightly smaller
sohkai c8bf479
Finance: consolidate rendering of balances' empty state with non-empt…
sohkai 46b925f
Finance: update for ButtonText
sohkai 7ba1b03
Finance: state's proxyAddress is the finance app's proxy address, not…
sohkai 8891cea
Finance: update empty transactions to say loading if still syncing
sohkai 5d7942b
Finance: remove dead code
sohkai fad188c
Finance: prefer Tabs over TabBar
sohkai a96aa3e
Finance: update for newstyle Field and TextInput components
sohkai e593d3d
Finance: update for newstyle Link
sohkai 1d99854
Finance: fix export icon spacing
sohkai c8683e1
Finance: clarify reference field is optional in panels
sohkai ab4d89b
Finance: update empty transactions with loading ring
sohkai 8a0ef7a
Finance: change deposit panel's spacing to be more consistent with ot…
sohkai a5e0d00
Finance: update to new Button API
sohkai 875a12f
Finance: simplify TokenSelectorInstance
sohkai 25fac75
Finance: update TokenSelector API to be closer to DropDown's
sohkai 8e72afa
Finance: update to use new ContextMenu API
sohkai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"version": 2, | ||
"public": true, | ||
"scope": "aragon", | ||
"name": "finance", | ||
"alias": "nightly-finance.aragon.org", | ||
"builds": [ | ||
{ "src": "package.json", "use": "@now/static-build", "config": { "distDir": "build" } } | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is the way we'd like to solve this. We should probably find a more generic solution to this with @bpierre.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @chadoh maybe he has 2 satoshis to share on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should try to avoid requiring boilerplate CSS to make aragonUI components work, if possible.
A solution might be to use
BaseStyles
for this, and useLayout
for theheight: 100%
+overflow: auto
(the same wayAppView
was doing it).The idea with Layout is that it can be nested to set another width (to simulate the behavior of iframe apps on internal apps or global settings), so we should ensure it works properly in these cases. We should also make sure this works well with the client itself.
Another solution I can see would be to apply
overflow: hidden
tohtml
andbody
when the SidePanel starts its opening transition, but it would create a jump :-/There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I want to avoid that as it is the
JS
solution and I think this can be solved by setting the right css rules.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
html
andbody
overflow hidden is more of a safeguard as#root
should not take more than100vh
, what I'm thinking is should/could we provide amain
container for apps for this or should app developers be responsible for it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should provide it yes :-) If we want to avoid having another component,
Layout
seems the best place to do that? We could add in the documentation that if the layout is disabled (onMain
), then it is the author’s responsibility to do it.