Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payroll: Fix accrued salary maths #926

Merged
merged 2 commits into from
Jul 17, 2019
Merged

Payroll: Fix accrued salary maths #926

merged 2 commits into from
Jul 17, 2019

Conversation

facuspagnuolo
Copy link
Contributor

No description provided.

@facuspagnuolo facuspagnuolo requested a review from sohkai July 17, 2019 02:08
@facuspagnuolo facuspagnuolo self-assigned this Jul 17, 2019
@auto-assign auto-assign bot requested a review from bpierre July 17, 2019 02:08
@coveralls
Copy link

coveralls commented Jul 17, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.5%) to 98.0% when pulling 5c52a69 on payroll/fix_accrued_salary_maths into 7988a73 on master.

sohkai
sohkai approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facuspagnuolo facuspagnuolo merged commit 04af12e into master Jul 17, 2019
@facuspagnuolo facuspagnuolo deleted the payroll/fix_accrued_salary_maths branch July 17, 2019 15:19
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
@facuspagnuolo
Payroll: Fix accrued salary maths (aragon#926)
9244544 
* payroll: fix accrued salary maths

* Payroll: add explicit tests for remaining accrued salary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohkai sohkai sohkai approved these changes

@bpierre bpierre Awaiting requested review from bpierre

Assignees

@facuspagnuolo facuspagnuolo

Labels
component: contract
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@facuspagnuolo @coveralls @sohkai