Payroll: cover cases for moving extra pay from payday into accrued salary #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -301,20 +309,13 @@ contract('Payroll payday', ([owner, employee, anyone]) => { | |||
|
|
|||
| context('when the requested amount is lower than the total owed salary', () => { | |||
| context('when the requested amount represents less than a second of the earnings', () => { | |||
| const requestedAmount = salary.div(2) | |||
| const requestedAmount = salary.div(2).floor() | |||
There was a problem hiding this comment.
This is what I noticed yesterday, after turning the base salary to 1 USD per second, these amount calculations became flaky
Co-Authored-By: Facu Spagnuolo <facuspagnuolo@users.noreply.github.com>
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified a few of the tests to try and cover the case we had with
payday()'s extra remainder salary being moved into the employee's accrued salary.