Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve invalid script handling #885

Merged
merged 3 commits into from
Jun 6, 2019
Merged

Improve invalid script handling #885

merged 3 commits into from
Jun 6, 2019

Conversation

2color
Copy link
Contributor

@2color 2color commented Jun 6, 2019

What

  • description takes precedence over metadata
  • Render description first
  • Do not nullify metadata for invalid scripts

Example

For /#/futhorcecosystem/0xd9ed670476974e371607c9a6f8bffd44462510af with an invalid vote:
Screen Shot 2019-06-06 at 7 38 24 pm

@2color 2color requested a review from izqui June 6, 2019 17:46
@izqui izqui merged commit e90e69b into master Jun 6, 2019
@2color 2color deleted the improve-invalid-script-handling branch June 7, 2019 08:13
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
@2color @izqui
Improve invalid script handling (aragon#885)
2f9859e 
* Description takes precedence in voting card

* Reorder description and metadata (question)

* Do not nullify metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izqui izqui izqui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2color @izqui