Rename Token Manager to Tokens #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
reviewed
May 24, 2019
There was a problem hiding this comment.
@delfipolito @dizzypaty What do you think about keeping the "canonical" name of this app the "Token Manager", but we can use the shorthand "Tokens" as the menu name?
As the app is built now, it's confusing to completely drop the "Manager" aspect out of it, especially when so much of code and documentation relies on this terminology.
apps/token-manager/app/src/components/Panels/AssignVotePanelContent.js
Outdated
Show resolved
Hide resolved
|
LGTM |
bpierre
reviewed
May 30, 2019
apps/token-manager/app/src/components/Panels/AssignVotePanelContent.js
Outdated
Show resolved
Hide resolved
luisivan
changed the title
bpierre
approved these changes
May 30, 2019
dizzypaty
approved these changes
May 30, 2019
There was a problem hiding this comment.
IMO it’s ok to change to Tokens in the rest of the UI. When we’ll review all copies, we’ll probably find ourselves having to adjust some info to make sense of it with the new name. But in the example you provided, I think the suggestion of changing the title to ‘Action’ instead of ‘Tokens action’ makes the most sense.
MickdeGraaf
pushed a commit
to MickdeGraaf/aragon-apps
that referenced
this pull request
Jan 28, 2020
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.