Edit label action on table's contextual menu #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delfipolito
requested review from
bpierre and
sohkai
and removed request for
sohkai
delfipolito
changed the title
sohkai
reviewed
May 16, 2019
| @@ -9,6 +9,38 @@ const IdentityContext = React.createContext({ | |||
| Promise.reject(Error('Please set resolve using IdentityProvider')), | |||
| }) | |||
|
|
|||
| export function useIdentity(address) { | |||
There was a problem hiding this comment.
Let's move this down to the end of the file, and export it in the same export declaration as the other components here.
| setName(metadata ? metadata.name : null) | ||
| } | ||
|
|
||
| const handleShowLocalIdentityModal = address => { |
There was a problem hiding this comment.
This and handleNameChange() could use useCallback()s
| } | ||
| }) | ||
| return () => subscription.unsubscribe() | ||
| }, [address]) |
There was a problem hiding this comment.
This needs updates$ and handleNameChange in its dependencies.
| }, [transactionHash, network]) | ||
|
|
||
| const [label, showLocalIdentityModal] = useIdentity(entity) | ||
| const handleEditLabel = () => showLocalIdentityModal(entity) |
There was a problem hiding this comment.
This (and the equivalent in HolderRow) could be wrapped in a useCallback()
bpierre
approved these changes
May 16, 2019
|
Small nitpick, on the Token Manager, the spacing and stroke color looks a bit odd for the icon:
|
MickdeGraaf
pushed a commit
to MickdeGraaf/aragon-apps
that referenced
this pull request
Jan 28, 2020
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.