Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voting - use updated app API with caching and init #836

Merged
merged 6 commits into from
May 29, 2019
Merged

Voting - use updated app API with caching and init #836

merged 6 commits into from
May 29, 2019

Conversation

2color
Copy link
Contributor

@2color 2color commented May 6, 2019 •
edited
Loading

What

  • Replace the INITIALIZATION_TRIGGER with an init function (part of the new API)
  • Use the new ACCOUNTS_TRIGGER build into the updated API

Related PR

@2color 2color requested review from bpierre and sohkai May 6, 2019 14:50
@coveralls
Copy link

coveralls commented May 6, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 97.015% when pulling ca8bf17 on voting-use-init-api into 56909c5 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.015% when pulling d49276a on voting-use-init-api into 4b5094a on master.

@2color 2color mentioned this pull request May 9, 2019
Merged
8 tasks
@2color 2color changed the title Replace the INITIALIZATION_TRIGGER with an init function [WIP] Replace the INITIALIZATION_TRIGGER with an init function May 9, 2019
@2color 2color changed the title [WIP] Replace the INITIALIZATION_TRIGGER with an init function [WIP] Voting - replace the INITIALIZATION_TRIGGER with an init function May 9, 2019
@2color 2color changed the title [WIP] Voting - replace the INITIALIZATION_TRIGGER with an init function [WIP] Voting - use updated API May 9, 2019
@2color 2color changed the title [WIP] Voting - use updated API [WIP] Voting - use updated app API May 9, 2019
@2color 2color changed the title [WIP] Voting - use updated app API Voting - use updated app API May 15, 2019
@2color 2color changed the title Voting - use updated app API Voting - use updated app API with caching and init May 16, 2019
@2color 2color force-pushed the voting-use-init-api branch from ebb0155 to ca8bf17 Compare May 16, 2019 07:15
@luisivan luisivan mentioned this pull request May 27, 2019
Closed
25 tasks
@bpierre bpierre mentioned this pull request May 29, 2019
Merged
@2color 2color merged commit 9301bc9 into master May 29, 2019
@2color 2color deleted the voting-use-init-api branch May 29, 2019 13:20
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
@2color
Voting - use updated app API with caching and init (aragon#836)
a1ba052 
* Move initial state loading to an init function

* Use accounts trigger from API

* Remove unnecassary imports

* Remove unneeded imports

* Voting: display the syncing state (aragon#875)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpierre bpierre Awaiting requested review from bpierre

@sohkai sohkai Awaiting requested review from sohkai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2color @coveralls @bpierre