Voting app: clarify polls #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
reviewed
Apr 17, 2019
| <Form onSubmit={this.handleSubmit}> | ||
| <Field label="Question"> | ||
| <TextInput | ||
| ref={question => (this.questionInput = question)} |
There was a problem hiding this comment.
It would be nice if we focused this input on navigating back to the tab.
sohkai
reviewed
Apr 17, 2019
| )} | ||
| {screenIndex === 1 && ( | ||
| <div> | ||
| <p css="margin: 30px 0 20px">Coming soon!</p> |
There was a problem hiding this comment.
Not sure if we decided on keeping this @dizzypaty
There was a problem hiding this comment.
@sohkai Mmm... we can keep it if we plan to eventually make it available from here (#582 (comment)). Otherwise I'm fine with removing it! I know this tab still feels a bit weird and empty but I'll definitely rethink this on the next iteration of the voting app.
There was a problem hiding this comment.
Yeah let's remove the Coming Soon part
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #582 and #732