Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finance: use aragonAPI for React #765

Merged
merged 5 commits into from
Apr 5, 2019
Merged

Finance: use aragonAPI for React #765

merged 5 commits into from
Apr 5, 2019

Conversation

bpierre
Copy link
Contributor

@bpierre bpierre commented Apr 5, 2019

Contains only the changes needed to support aragonAPI for React (not a full conversion to React Hooks).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.734% when pulling 8130eb3 on finance-react-api into aff584e on master.

@bpierre bpierre force-pushed the finance-react-api branch from 8130eb3 to 63221ce Compare April 5, 2019 09:14
@bpierre bpierre mentioned this pull request Apr 5, 2019
@bpierre bpierre requested a review from sohkai April 5, 2019 10:17
@luisivan luisivan mentioned this pull request Apr 5, 2019
46 tasks
@bpierre bpierre requested a review from 2color April 5, 2019 14:15
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🐎 🏇 🏎

We could do the MenuPanel change here too :).

apps/finance/app/src/App.js Show resolved Hide resolved
@bpierre bpierre merged commit e5078ff into master Apr 5, 2019
@bpierre bpierre deleted the finance-react-api branch April 5, 2019 17:06
@2color
Copy link
Contributor

2color commented Apr 8, 2019

🎆👏🏼🥊

ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
Only contains the changes needed to support aragonAPI for React: this is not a full conversion to React Hooks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants