Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent: replicate rate conversion strategy from #1177 #1200

Merged
merged 3 commits into from
Jul 14, 2020

Conversation

Evalir
Copy link
Contributor

@Evalir Evalir commented Jul 9, 2020

Replicates conversion strategy used in #1177.

Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

symbol,
verified,
}))
return balances.map(({ address, amount, decimals, symbol, verified }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick: leaving the implicit return (({) would have made these changes smaller :).

@Evalir Evalir merged commit 7fc0b9b into master Jul 14, 2020
@Evalir Evalir deleted the agent-update-conversion-bn branch July 14, 2020 14:26
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
* Agent: replicate rate conversion strategy from aragon#1177

* Remove unused parameter

* Remove redundant return on map :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants