Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voting: migrate date format to ISO-8601 #1165

Merged
merged 3 commits into from
Jun 16, 2020
Merged

Voting: migrate date format to ISO-8601 #1165

merged 3 commits into from
Jun 16, 2020

Conversation

ECWireless
Copy link
Contributor

@ECWireless ECWireless commented Jun 13, 2020 •
edited by sohkai
Loading

Fixes issue #1161.

@auto-assign auto-assign bot requested review from bpierre and Evalir June 13, 2020 23:52
@ECWireless
Copy link
Contributor Author

@sohkai @bpierre I believe the only other date display in the Voting App is in the Votes.js component, but I think that involves updating DateRangePicker.js in aragon/ui (?)

@sohkai
Copy link
Contributor

sohkai commented Jun 15, 2020 •
edited
Loading

I think that involves updating DateRangePicker.js in aragon/ui (?)

This is controllable via DateRangePicker's format prop.

We should most likely also update aragonUI's default in the future, but that would be a breaking change.

Could you also upload a screenshot of what the new version looks like :)?

@ECWireless
Copy link
Contributor Author

@sohkai Got it! Here are screenshots of all the changes:

From VotesDetail.js...

Passed Vote

From Votes.js (DateRangePicker)...

DateRangePicker

This date is displayed during a pending vote, but I'm unsure if it requires reformatting (?) ...

Pending Vote

sohkai
sohkai approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ All looks good for me! Thanks again @ECWireless!

This date is displayed during a pending vote, but I'm unsure if it requires reformatting

I think this one is OK, since it's in prose :).

@sohkai sohkai changed the title Voting: migrate date format to ISO -8601 Voting: migrate date format to ISO-8601 Jun 16, 2020
bpierre
bpierre approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sohkai sohkai merged commit ca8b6de into aragon:master Jun 16, 2020
@ECWireless ECWireless deleted the voting-update-date-format branch June 16, 2020 15:41
@sohkai sohkai mentioned this pull request Jun 25, 2020
Closed
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
@ECWireless
Voting: migrate date format to ISO-8601 (aragon#1165)
128bbc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpierre bpierre bpierre approved these changes

@sohkai sohkai sohkai approved these changes

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
app: voting component: frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ECWireless @sohkai @bpierre