Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finance: fix withdrawal panel not detecting tokens #1159

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

sohkai
Copy link
Contributor

@sohkai sohkai commented Jun 10, 2020

Oops, we actually need that amount state in the tokens array!

Finance still has a lot of older React class components, but in the future, we should migrate to functional components so we can use hooks and api-react to fetch app state so we don't have to pass this down :).

Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@sohkai sohkai merged commit 1753751 into master Jun 10, 2020
@sohkai sohkai deleted the finance-fix-withdrawal branch June 10, 2020 16:47
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants