Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finance: disable tree-shaking #1083

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Finance: disable tree-shaking #1083

merged 1 commit into from
Feb 19, 2020

Conversation

sohkai
Copy link
Contributor

@sohkai sohkai commented Feb 19, 2020

@bpierre Reversing the build-time configuration change from #1078.

Producing a build via npm run build in Finance is failing with a cryptic Uncaught ReferenceError: module is not defined.

Perhaps it's because we haven't published the tree-shaking enabled version of aragonUI yet?

@sohkai sohkai requested a review from bpierre February 19, 2020 04:39
@sohkai sohkai merged commit 41d546b into master Feb 19, 2020
@sohkai sohkai deleted the finance-disable-tree-shaking branch February 19, 2020 04:39
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant