Voting: avoid crashing when external app details are not loadable #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen when the external app's artifacts aren't loadable. In general we should prefer doing operations using the external app's address, as this is always available.
…e could not be loaded
bpierre
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
LGTM!
The importance of re-spec'ing the data structures involved with apps is becoming clearer, as it'll let us more clearly mark whether something is always going to be available or not from aragon.js.
Agreed, do you think it should happen in the background script?
| address: appAddress, | ||
| name, | ||
| // If the app name was not loaded, use the app's address | ||
| name: name || appAddress, |
There was a problem hiding this comment.
Wondering if we should use the shortened version here?
There was a problem hiding this comment.
Yes, let's do that! Done in ccb6e2b.
This will need to happen starting from |
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
…agon#1066) The external app details are not available when we can't load the the external app's artifacts. In general we should prefer doing operations using the external app's address, as this will always be available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things like an app's name come from IPFS, and may not be available all the time.
The importance of re-spec'ing the data structures involved with apps is becoming clearer, as it'll let us more clearly mark whether something is always going to be available or not from aragon.js.