Tokens: refactor the side panel as a function component #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And make use of useSidePanelFocusOnReady().
sohkai
reviewed
Nov 22, 2019
| onChange={this.handleAmountChange} | ||
| min={minTokenStep} | ||
| max={amountField.max} | ||
| disabled={accountMaxed} |
There was a problem hiding this comment.
accountMaxed, or find a different mechanism to handle it (e.g. handling it during updateAmount()).
Right now, the form doesn't stop you from trying to assigning or removing too many tokens.
| tokenDecimals, | ||
| tokenDecimalsBase, | ||
| }) { | ||
| const holderInputRef = useSidePanelFocusOnReady() |
There was a problem hiding this comment.
I think it should be fairly easy to do with the useSidePanel() hook, but it would be nice if we instead focused on the amount input if the holderAddress was already populated.
Also: - Rename the component to UpdateTokenPanel. - Change the label to be more explicit: “Number of tokens to remove”.
sohkai
approved these changes
Nov 26, 2019
apps/token-manager/app/src/App.js
Outdated
| @@ -212,5 +204,10 @@ export default () => { | |||
| const theme = useTheme() | |||
| const { layoutName } = useLayout() | |||
|
|
|||
| const themeMode = useThemeMode() | |||
There was a problem hiding this comment.
Should we remove this for now?
There was a problem hiding this comment.
Oops this was for a local demo, it shouldn’t have been committed :o
MickdeGraaf
pushed a commit
to MickdeGraaf/aragon-apps
that referenced
this pull request
Jan 28, 2020
* TokenPanelContent: move to a function component * UpdateTokenPanel: add more warnings * Tokens: add warning if amount field is too small or has too much precision
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
* TokenPanelContent: move to a function component * UpdateTokenPanel: add more warnings * Tokens: add warning if amount field is too small or has too much precision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And make use of
useSidePanelFocusOnReady().