Voting: fix a description overflow issue #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
approved these changes
Oct 17, 2019
| // which is why word-break:break-word has been added. | ||
| hyphens: auto; | ||
| overflow-wrap: anywhere; | ||
| word-break: break-word; |
There was a problem hiding this comment.
Should we put this in VoteText instead?
There was a problem hiding this comment.
Yes maybe we could: VoteText is inline but it’s only used as a block, the structure must be coming from a need in the previous version. Changing it 👍
sohkai
reviewed
Oct 17, 2019
| /* lines per font size per line height */ | ||
| /* shorter texts align to the top */ | ||
| height: ${10.5 * GU}px; | ||
| height: ${27 * 3}px; // 27px = line-height with body1 |
There was a problem hiding this comment.
Maybe we can add a note to the comment about 3 being the number of lines we want
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before (notice the scrollbars):
After: