Payroll: Support removing allowed tokens #742
Labels
Comments
facuspagnuolo
added a commit
that referenced
this issue
Mar 26, 2019
facuspagnuolo
added a commit
that referenced
this issue
Mar 27, 2019
facuspagnuolo
added a commit
that referenced
this issue
Apr 5, 2019
* Fix payment overflow attack Remove MAX_ACCRUED_VALUE. Set amount to max int in case of overflow. * Revert preventing _addAccruedValue from reverting * Prevent owed amount in _paytokens from overflowing * Improve `assertThrow` to support promises as well * Split accrued value payments from regular payroll * Payroll: Use `uint256` when possible * Payroll: Move TODO comment to issue (see #742) * Payroll: Move auth to be the first modifier * Payroll: Keep forwarding functions together * Payroll: Include employee's enddate within their active period * Payroll: Add existence checks protecting getters * Payroll: Cleanup empty lines * Payroll: Polish initialize test file * Payroll: Polish add/remove employees test file * Payroll: Polish forward test file * Payroll: Polish allowed tokens test file * Payroll: Polish price feed test file * Payroll: Polish accrued value test file * Payroll: Polish modify employee test file * Payroll: Improve reimbursements tests * Payroll: Fix partial payday computation * Payroll: Polish payday test file * Payroll: Optimize employee removal costs * Payroll: Unify test files * Payroll: Remove unused mock contracts * Payroll: Handle last payroll date overflow * Payroll: Polish and add missing inline documentation * Payroll: Add missing test cases * Payroll: Sanity-check last payroll date for partial payrolls * Payroll: Fix inline doc wording Co-Authored-By: facuspagnuolo <facuspagnuolo@users.noreply.github.com> * Payroll: Fix mock timestamp helpers * Payroll: Re-add migrations contract * Payroll: Fix payroll date casting * Payroll: Split tests into separate files * Payroll: Remove name argument to add employees * Payroll: Contract improvements * Payroll: Tests improvements
|
Fixed in #904. |
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this issue
Dec 9, 2021
* Fix payment overflow attack Remove MAX_ACCRUED_VALUE. Set amount to max int in case of overflow. * Revert preventing _addAccruedValue from reverting * Prevent owed amount in _paytokens from overflowing * Improve `assertThrow` to support promises as well * Split accrued value payments from regular payroll * Payroll: Use `uint256` when possible * Payroll: Move TODO comment to issue (see aragon#742) * Payroll: Move auth to be the first modifier * Payroll: Keep forwarding functions together * Payroll: Include employee's enddate within their active period * Payroll: Add existence checks protecting getters * Payroll: Cleanup empty lines * Payroll: Polish initialize test file * Payroll: Polish add/remove employees test file * Payroll: Polish forward test file * Payroll: Polish allowed tokens test file * Payroll: Polish price feed test file * Payroll: Polish accrued value test file * Payroll: Polish modify employee test file * Payroll: Improve reimbursements tests * Payroll: Fix partial payday computation * Payroll: Polish payday test file * Payroll: Optimize employee removal costs * Payroll: Unify test files * Payroll: Remove unused mock contracts * Payroll: Handle last payroll date overflow * Payroll: Polish and add missing inline documentation * Payroll: Add missing test cases * Payroll: Sanity-check last payroll date for partial payrolls * Payroll: Fix inline doc wording Co-Authored-By: facuspagnuolo <facuspagnuolo@users.noreply.github.com> * Payroll: Fix mock timestamp helpers * Payroll: Re-add migrations contract * Payroll: Fix payroll date casting * Payroll: Split tests into separate files * Payroll: Remove name argument to add employees * Payroll: Contract improvements * Payroll: Tests improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Removing allowed tokens isn't that trivial. Based on how data is stored currently, employees should modify their allocation as well, which can be done by notifying them and reseting their last allocation date.
The text was updated successfully, but these errors were encountered: