Skip to content

Commit

Permalink
Remove isInitialized mod from some functions
Browse files Browse the repository at this point in the history
Addressing PR #307 comments.
  • Loading branch information
ßingen committed May 14, 2018
1 parent bb6a18d commit e906b43
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions apps/token-manager/contracts/TokenManager.sol
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ contract TokenManager is ITokenController, AragonApp { // ,IForwarder makes cove
* @param _owner The address that sent the ether to create tokens
* @return True if the ether is accepted, false for it to throw
*/
function proxyPayment(address _owner) payable isInitialized public returns (bool) {
function proxyPayment(address _owner) payable public returns (bool) {
// Even though it is tested, solidity-coverage doesnt get it because
// MiniMeToken is not instrumented and entire tx is reverted
require(msg.sender == address(token));
Expand All @@ -365,7 +365,7 @@ contract TokenManager is ITokenController, AragonApp { // ,IForwarder makes cove
* @param _amount The amount in the `approve()` call
* @return False if the controller does not authorize the approval
*/
function onApprove(address _owner, address _spender, uint _amount) isInitialized public returns (bool) {
function onApprove(address _owner, address _spender, uint _amount) public returns (bool) {
_owner;
_spender;
_amount;
Expand Down
3 changes: 1 addition & 2 deletions apps/vault/contracts/Vault.sol
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ contract Vault is VaultBase {
connectors[ETH] = ethConnector;
}

function () payable isInitialized public {
function () payable public {
address token = ETH;

// 4 (sig) + 32 (at least the token address to locate connector)
Expand All @@ -74,7 +74,6 @@ contract Vault is VaultBase {

function registerStandard(uint32 erc, uint32 interfaceDetectionERC, bytes4 interfaceID, address connector)
authP(REGISTER_TOKEN_STANDARD, arr(uint256(erc), interfaceDetectionERC))
isInitialized
public
{

Expand Down

0 comments on commit e906b43

Please sign in to comment.