Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ThumbCluster keycodes and update layout configurations. Thi… #385

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

domelqq
Copy link
Contributor

@domelqq domelqq commented Feb 5, 2025

Some of the new type of matrix layouts are using thumb cluster section to put there one or two letters.
Hands down promethium is such one
https://www.reddit.com/r/KeyboardLayouts/comments/1g66ivi/hands_down_promethium_snth_meets_hd_silverengram/
With current configuration letter R is not in the matrix layout and because of that is also excluded from lessons.

PR adds two thumb buttons on each side that any of the matrix layouts can later use it.
With letter in thumb cluster emulation does not make sense as there is no fifth row on standard keyboard.

With the change R is correctly added to lessons.
Thanks - great tool

…s is mainly for matrix layouts with letter in thumb cluster area.
Copy link

semanticdiff-com bot commented Feb 5, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  packages/keybr-keyboard-io/lib/keys.ts  0% smaller
  packages/keybr-keyboard/lib/geometry/matrix.ts  0% smaller
  packages/keybr-keyboard/lib/keycode.ts  0% smaller
  packages/keybr-keyboard/lib/layout.ts  0% smaller
  packages/keybr-keyboard/lib/layout/en_hands_down_promethium.ts  0% smaller

@aradzie
Copy link
Owner

aradzie commented Feb 5, 2025

Something is not right with the tests, they are failing.
I'll take a closer look tomorrow (I live in Europe) and then will suggest fixes to your PR or merge it as is and fix the tests myself.
Anyway, thanks for your contribution!

@domelqq
Copy link
Contributor Author

domelqq commented Feb 5, 2025

Something is not right with the tests, they are failing. I'll take a closer look tomorrow (I live in Europe) and then will suggest fixes to your PR or merge it as is and fix the tests myself. Anyway, thanks for your contribution!

Yeah its late here. Cheers from Poland :)

@aradzie aradzie merged commit 639a036 into aradzie:master Feb 6, 2025
@aradzie
Copy link
Owner

aradzie commented Feb 6, 2025

I updated the web site with your changes.
Thanks again!

@domelqq
Copy link
Contributor Author

domelqq commented Feb 6, 2025

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants