feat(PE-7274): funding source #636

atticusofsparta · 2025-01-02T17:38:57Z

No description provided.

github-actions · 2025-01-02T17:51:49Z

Visit the preview URL for this PR (updated for commit 95b8cde):

https://arns-portal--pr636-pe-7274-funding-sour-i6l72crv.web.app

_{(expires Tue, 21 Jan 2025 14:41:56 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 1f59769442cb89cf2a92042a342e51fe94047b94}

dtfiedler · 2025-01-02T18:55:48Z

.storybook/main.ts

+import type { StorybookConfig } from '@storybook/react-vite';
+
+const config: StorybookConfig = {
+  stories: ['../src/**/*.mdx', '../src/**/*.stories.@(js|jsx|mjs|ts|tsx)'],
+
+  addons: [
+    '@storybook/addon-onboarding',
+    '@storybook/addon-essentials',
+    '@chromatic-com/storybook',
+    '@storybook/addon-interactions',
+  ],
+
+  framework: {
+    name: '@storybook/react-vite',
+    options: {},
+  },
+
+  typescript: {
+    reactDocgen: 'react-docgen-typescript',
+  },
+};
+export default config;


will always be my rec to introduce new tools in separate and isolated PRs

I will endeavour to do so in the future.

kunstmusik · 2025-01-02T23:09:44Z

src/utils/common/common.tsx

 };

+export function formatARIOWithCommas(ario: number) {
+  return ario.toLocaleString('en-US', {


Seems odd/inconsistent we have two functions for formatting ARIO values, one with 3 digits and one with 2.

Well its for different circumstances, one is long form one is short form. In this context we have a dropdown that we want to represent the numbers as compact as possible, and we have a larger area we want to display the numbers long form.

src/state/actions/dispatchArIOInteraction.ts

src/hooks/useCostDetails.tsx

src/hooks/useBalance.tsx

src/components/pages/Transaction/TransactionReview.tsx

src/components/modals/PrimaryNameModal/PrimaryNameModal.tsx

kunstmusik · 2025-01-06T15:46:10Z

src/components/layout/UpgradeUndernames/UpgradeUndernames.tsx

-  const [record, setRecord] = useState<AoArNSNameData>();
-  const [antContract, setAntContract] = useState<ANT>();
-  const [undernameCount, setUndernameCount] = useState<number>(0);
+  // const [record, setRecord] = useState<AoArNSNameData>();


Remove dead code

atticusofsparta added 5 commits December 18, 2024 13:14

fix(storybook): added storybook for component development

4742fcf

fix(funding source selecting): added funding source component

808b99b

merge remote

017342a

fix(cost details): add cost details to review components

72fe4e2

fix(funding selector): switch sizing to fixed with fit as min

3439f37

atticusofsparta requested a review from a team as a code owner January 2, 2025 17:38

atticusofsparta temporarily deployed to develop January 2, 2025 17:49 — with GitHub Actions Inactive

dtfiedler reviewed Jan 2, 2025

View reviewed changes