fix(nav menu): add ant logo associate with primary name to nav menu #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atticusofsparta
temporarily deployed
to
develop
GitHub Actions
Inactive
|
Visit the preview URL for this PR (updated for commit e1c23b3): https://arns-portal--pr628-pe-7279-logo-primary-zwv9owb6.web.app (expires Thu, 02 Jan 2025 20:23:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1f59769442cb89cf2a92042a342e51fe94047b94 |
atticusofsparta
temporarily deployed
to
develop
GitHub Actions
Inactive
atticusofsparta
temporarily deployed
to
develop
GitHub Actions
Inactive
kunstmusik
reviewed
Dec 18, 2024
| className="rounded-full max-h-[1.875rem] border border-dark-grey" | ||
| id={domainDomain?.info?.Logo} | ||
| icon={ | ||
| <div className="flex items-center justify-center rounded-full fill-white p-[5px]"> |
There was a problem hiding this comment.
In general need to stop using px and use rem by default. This will need to get fixed during audit.
kunstmusik
previously approved these changes
Dec 18, 2024
atticusofsparta
temporarily deployed
to
develop
GitHub Actions
Inactive
fix(PE-7345): reset valid logo state on id change
atticusofsparta
temporarily deployed
to
develop
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.